Added deepProp, deepTheme, and deepPalette #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegohaz
requested changes
Jan 30, 2019
Owner
diegohaz
left a comment
diegohaz
left a comment
There was a problem hiding this comment.
Thank you again @jtmthf. I made a few suggestions (a yarn lint --fix may be needed after applying them).
Also, I was thinking about, instead of separate functions, a single function resolvePaletteProps that would return { key, tone, defaultValue } and then used as:
const { key, tone, defaultValue: finalDefaultValue } = resolvePaletteProps(...);Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Co-Authored-By: Haz <[email protected]>
Collaborator
Author
|
@diegohaz I recently had a use for this project and I forgot that I still had this PR open. I applied your suggestions and cleaned a few things up if you're still interested in this feature. |
|
I'm looking forward the new feature to solve my recent problems, will this be merged? |
|
is there something else needed to merge this pr? |
|
Hey, @jtmthf Please, can you open this PR on my fork? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-closes #55. Adds
deepProp,deepTheme, anddeepPalette.