Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project dependencies #174

Merged
merged 6 commits into from
May 19, 2018
Merged

Update project dependencies #174

merged 6 commits into from
May 19, 2018

Conversation

pedro-victor
Copy link
Collaborator

  • Mongoose: 4.12 -> 5.1

  • ESLint: 4.4 -> 4.19

  • Mockgoose: dropped in favor of mongodb-memory-server

- Mongoose: 4.12 -> 5.1

- ESLint: 4.4 -> 4.19

- Mockgoose: dropped in favor of mongodb-memory-server
@pedro-victor
Copy link
Collaborator Author

This is my own version of rest and even though it passes the tests locally, it doesn't on TravisCI. I'll try to fix that another time.

@diegohaz
Copy link
Owner

Thank you for taking the time to work on this, @pedro-victor. I think the problem with Travis may be related to the Node version.

@pedro-victor
Copy link
Collaborator Author

Yes and it's definitely not that simple. I checked in my machine and I'm also not able to run npm test running Node v4-v6.

What do you think about upgrading Node requirements to version 8+? Since it's used only by brand new projects, I don't think that it would be such a bad idea.

I'll test again with upgraded versions, just in case.

@pedro-victor pedro-victor reopened this May 14, 2018
@diegohaz
Copy link
Owner

Doesn't it work with v7 either?

Anyway, I'm ok with upgrading Node version.

@pedro-victor
Copy link
Collaborator Author

I suggested v8 because that's the one I use. 😄

@coveralls
Copy link

coveralls commented May 14, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 03629a2 on pedro-victor:master into 4a6c3d5 on diegohaz:master.

@pedro-victor
Copy link
Collaborator Author

pedro-victor commented May 15, 2018

What I've done so far:

My suggestion is: merge this PR so we can benefit from upgraded versions and, as soon as we are able to upgrade yeoman-generator to v2, we add NSP back. @diegohaz what do you think?

@diegohaz diegohaz merged commit ebc9a01 into diegohaz:master May 19, 2018
@diegohaz
Copy link
Owner

Thank you very much, @pedro-victor. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants