Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] #1155 Consume just filter key or value, not both. 消费消息支持单独过滤key或者value. #1157

Open
wants to merge 2 commits into
base: ve_3.x
Choose a base branch
from

Conversation

chang-wd
Copy link
Contributor

@chang-wd chang-wd commented Sep 21, 2023

请不要在没有先创建Issue的情况下创建Pull Request。

变更的目的是什么

close #1155

简短的更新日志

Consume just filter key or value, not both.
消费消息支持单独过滤key或者value。

验证这一变化

image

请遵循此清单,以帮助我们快速轻松地整合您的贡献:

  • 一个 PR(Pull Request的简写)只解决一个问题,禁止一个 PR 解决多个问题;
  • 确保 PR 有对应的 Issue(通常在您开始处理之前创建),除非是书写错误之类的琐碎更改不需要 Issue ;
  • 格式化 PR 及 Commit-Log 的标题及内容,例如 [Bugfix]修复用户信息修改后,用户列表会抛出空指针异常的问题(#860) #861 。PS:Commit-Log 需要在 Git Commit 代码时进行填写,在 GitHub 上修改不了;
  • 编写足够详细的 PR 描述,以了解 PR 的作用、方式和原因;
  • 编写必要的单元测试来验证您的逻辑更正。如果提交了新功能或重大更改,请记住在 test 模块中添加 integration-test;
  • 确保编译通过,集成测试通过;

@chang-wd
Copy link
Contributor Author

不确定是否需要统一代码风格?
选项里有大小写的、下划线的、单纯小写+空格的。
image

@ZQKC ZQKC self-assigned this Sep 25, 2023
@ZQKC ZQKC assigned chang-wd and unassigned ZQKC Oct 15, 2023
@ZQKC
Copy link
Collaborator

ZQKC commented Oct 15, 2023

不确定是否需要统一代码风格? 选项里有大小写的、下划线的、单纯小写+空格的。 image

可以统一风格,按照Under Size这种风格进行统一。

@ZQKC
Copy link
Collaborator

ZQKC commented Oct 15, 2023

@chang-wd 后端代码没什么问题,前端我晚点找人看看啊,那个风格不一致的问题,辛苦调整为一致。感谢贡献!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Message->Consume just filter key or value, not both. 消费消息支持单独过滤key或者value
2 participants