docs: fix storybook input error #1594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1594--dhis2-ui.netlify.app |
|
This seems wrong to me. The component is within the If there is a circular dependency, meaning that |
|
It was a bit convoluted but I found the underlying issue and fixed it in #1602 - agree it's better not to import internal dependencies through the external package export |
|
Closing this in favour of the better fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error introduced with #1590 causing an error in storybook prod. Implements libs-674
Specifically tagging @KaiVandivier to check this as the circular dependency issue sounds like it needed solving too