docs: migrating demos to embed instead #1568
Conversation
|
🚀 Deployed on https://pr-1568--dhis2-ui.netlify.app |
Topener
changed the title
There was a problem hiding this comment.
💯 approved .. just the two comments we discussed on Slack (for future improvements):
-
I think the Reload button doesn't add a lot of value, but as you said you intend to add more interactive demos and then it might be useful for it to reset state (I would all it "Reset" though, or just have a reload icon or something more subtle)
-
I think the two buttons (reload + show full demo) can be designed a bit more inline with the rest of the page .. they feel a bit jarring for me (@cooper-joe might have better input here though)
Finally, I think we can remove the demo links next. They're redundant now as we have links in all the embedded stories
There was a problem hiding this comment.
A few suggestions for the button styling.
Agreed with @kabaros about renaming Reload to Reset demo. I also think it might be worth omitting this button for now until we have the interactive functionality in place.
Co-authored-by: Joe Cooper <[email protected]>
Co-authored-by: Joe Cooper <[email protected]>
Co-authored-by: Joe Cooper <[email protected]>
Co-authored-by: Joe Cooper <[email protected]>
|
@cooper-joe @kabaros there are already some demo's that do allow altering (such as the alert bar) which makes the reloading of the demo important. I could make it optional and only show it when it allows for it, but I guess that's an improvement we can handle later. |
This is a big revamp of the documentation to remove UI library dependency on the docs itself. This is to prepare the docs being merged into the developer portal.
The buttons on the demo component are still pending review from @cooper-joe so he's added as a reviewer here too.
Jira ticket: https://dhis2.atlassian.net/browse/LIBS-666