Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: bundle global app shell #20171

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

feat: bundle global app shell #20171

wants to merge 16 commits into from
+141 −49

Conversation

amcgee
Copy link
Member

@amcgee amcgee commented Mar 5, 2025 •
edited
Loading

Follow-on to #20074

@amcgee amcgee added the deploy Deploy DHIS2 instance with IM. label Mar 5, 2025
Base automatically changed from fix-apps-menu-keys to master March 5, 2025 11:23
@amcgee amcgee added deploy Deploy DHIS2 instance with IM. and removed deploy Deploy DHIS2 instance with IM. labels Mar 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025

Instance deployed to https://dev.im.dhis2.org/pr-20171

@amcgee amcgee force-pushed the feat-bundle-global-shell branch from aa8fe8c to a65bd44 Compare March 11, 2025 11:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 New issue
1 New Critical Issues (required ≤ 0)
1 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 13, 2025
View reviewed changes
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/AppHtmlTemplate.java
PrintWriter output = new PrintWriter(outputStream, true, StandardCharsets.UTF_8);
try {
while (iterator.hasNext()) {
String line = iterator.nextLine();

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking
LineIterator.nextLine
Loading
should be avoided because it has been deprecated.

Copilot Autofix AI about 1 hour ago

To fix the problem, we need to replace the deprecated LineIterator.nextLine() method with its recommended alternative. The LineIterator class provides the next() method, which can be used instead of nextLine(). This method returns the next line in the iteration, similar to nextLine().

  • Replace the call to iterator.nextLine() with iterator.next().
  • Ensure that the functionality remains the same by verifying that iterator.next() returns the same type of data (a line of text) as iterator.nextLine().
Suggested changeset 1
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/AppHtmlTemplate.java

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/AppHtmlTemplate.java b/dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/AppHtmlTemplate.java
--- a/dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/AppHtmlTemplate.java
+++ b/dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/AppHtmlTemplate.java
@@ -50,3 +50,3 @@
       while (iterator.hasNext()) {
-        String line = iterator.nextLine();
+        String line = iterator.next();
         output.println(replaceLine(line));
EOF
@@ -50,3 +50,3 @@
while (iterator.hasNext()) {
String line = iterator.nextLine();
String line = iterator.next();
output.println(replaceLine(line));
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deploy Deploy DHIS2 instance with IM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amcgee