Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: adjust the level of the root when deleting nodes #60

Conversation

tyrzhang
Copy link

bugfix: adjust the level of the root when deleting nodes

when the tree is deep, and deleting nodes, will cause the issue.
the tree could be like this: one obj but 3 levels depth.

{
  "size": 1,
  "depth": 3,
  "root": {
    "entries": [
      {
        "bb": "[1.00, 2.00]x[1.00, 2.00]",
        "child": {
          "entries": [
            {
              "bb": "[1.00, 2.00]x[1.00, 2.00]",
              "child": {
                "leaf": true,
                "entries": [
                  {
                    "bb": "[1.00, 2.00]x[1.00, 2.00]"
                  }
                ]
              }
            }
          ]
        }
      }
    ]
  }
}

so we need to merge the root in loop, instead of once.

@tyrzhang tyrzhang force-pushed the bugfix/tyr_delete_all_in_different_order branch from e748c4e to 1cd5974 Compare December 20, 2024 02:49
@hanyuancheung
Copy link

We've met the same problem, @dhconnelly could you please help to review this PR, so we could fix the Production issue.
Thanks.

@dhconnelly
Copy link
Owner

looks great, thanks again!

@dhconnelly dhconnelly merged commit 9d74c6b into dhconnelly:master Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants