Fix broken link to Twitter in newsletter #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like the site was migrated at some point from Hugo to Astro, and this link got left behind. I haven't tested this, as I don't know how to build the site, but I copied the example from src/layouts/BlogPostLayout.astro
|
Hey @mtlynch, thanks so much for noticing and taking the time to make a PR! The fix didn't quite do it. I checked the Netlify deploy preview, and the link looked like this: So something went wrong with the interpolation. But I pushed a new commit and added a Mastodon link while I was at it. And this is a total tangent, but I recognized your name from your blog posts! Particularly the ones on bootstrapping TinyPilot. Thank you for writing about your experience. It's very inspiring. |
dguo
reviewed
Apr 15, 2024
| @@ -9,7 +9,7 @@ import BaseLayout from "../layouts/BaseLayout.astro"; | |||
| .push(arguments);},l=d.createElement(e),l.async=1,l.src=u, | |||
| n=d.getElementsByTagName(e)[0],n.parentNode.insertBefore(l,n);}) | |||
| (window,document,'script','https://assets.mailerlite.com/js/universal.js','ml'); | |||
| ml('account', '796104'); | |||
| ml("account", "796104"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the site was migrated at some point from Hugo to Astro, and this link got left behind.
I haven't tested this, as I don't know how to build the site, but I copied the example from
src/layouts/BlogPostLayout.astro.