requirements/chore: temporary dnspython<2.6 pin #2202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constantin1489
changed the title
Constantin1489
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
|
fixed 904ef84 :) |
|
I think this is all related to #2029 because we can remove gevent/dnspython/etc |
|
@dgtlmoon At this time, gevent basic setting is ready. Also, your options in gevent is a base option in gevent. So it's good by now. However, recently you added asyncio function. I hope you add a related asyncio function test because they use a different event loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: rthalley/dnspython#1050