Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Skip elementpath 4.2 but support since 4.1.5. #2175

Closed

Conversation

Constantin1489
Copy link
Contributor

@Constantin1489 Constantin1489 commented Feb 10, 2024

This allows installing elementpath4.2.1 (bug fix) with skipping 4.2.
Test cases are merged into the elementpath repo. sissaschool/elementpath@4aa9adb

@Constantin1489
Copy link
Contributor Author

Constantin1489 commented Feb 10, 2024

I reverted the fragment=False, It's because the reverted commit code and elementpath4.1.5 caused exception: XPath2Parser.__init__() got an unexpected keyword argument 'fragment'. for this, I will think about the solution.
Internally newer elementpath's fragment=False is default. So even without the argument, old behavior is assured.

@dgtlmoon
Copy link
Owner

no problems, let me know when its good to merge :)

@Constantin1489
Copy link
Contributor Author

Constantin1489 commented Feb 11, 2024

It's good to merge but I just want to take time.. I want to make some progress related to the i18n thing...

@Constantin1489
Copy link
Contributor Author

Since the newer PR(#2351) uses fragment=True option, >=4.1.5 won't work. So I closed this.

@Constantin1489 Constantin1489 deleted the elementpath_test branch May 16, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants