Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --generator=run-pod/v1 explicitly instead of --restart=Never #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stankevichevg
Copy link

Use --generator=run-pod/v1 explicitly instead of --restart=Never (not specified in the task)

@shay-berman
Copy link

BTW --restart=Never is still relevant, but i agree its better to use generator since its the new way.

@dgkanatsios
Copy link
Owner

Is the --restart=Never deprecated? If not, can we include it in a comment? I think it's easier for people to remember for the exam, but definitely agree that generator is the correct way.

@bvntejasvi
Copy link
Contributor

we should retain --restart=Never

@ojongerius
Copy link
Contributor

According to https://kubernetes.io/docs/reference/kubectl/conventions it's still good to use --restart=Never to create pods:

Generators other than run-pod/v1 are deprecated

@dgkanatsios
Copy link
Owner

I suppose we can add it as a comment, in any case.

@StevenJDH
Copy link
Contributor

Generated shouldn't be use anyways, this was deprecated and will be removed in 1.20 https://kubernetes.io/docs/setup/release/notes/#changelog-since-v1-20-0. This topic also kind of touches with my pull request #167, which depending on the top of pod image we need to set the restart policy or keep the default.

@mjrulesamrat
Copy link

@stankevichevg Can you rebase your branch with the latest master and update the PR with reviews if you're still at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants