Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify explanation for exposed ports for httpGet in probes #312

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: simplify explanation for exposed ports for httpGet in probes #312

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9df5282
refactor: simplify explanation for exposed ports for httpGet in probes
BoboTheBarbar Mar 10, 2023
dbe13d9
Merge branch 'main' into simplify-readinessprobe-answer
dgkanatsios Apr 3, 2023
f559c5b
docs: clarifies documentation on port usage
BoboTheBarbar Apr 8, 2023
692083d
Merge branch 'main' into simplify-readinessprobe-answer
BoboTheBarbar Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions e.observability.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,10 @@ spec:
imagePullPolicy: IfNotPresent
name: nginx
resources: {}
ports:
- containerPort: 80 # Note: Readiness probes runs on the container during its whole lifecycle. Since nginx exposes 80, containerPort: 80 is not required for readiness to work.
readinessProbe: # declare the readiness probe
httpGet: # add this line
path: / #
port: 80 #
port: 80 # Since nginx exposes 80, exposing containerPort: 80 is not required for readiness to work.
dnsPolicy: ClusterFirst
restartPolicy: Never
status: {}
Expand Down