Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like with googlefonts/fontations#497, we were previously not falling back to phantom point deltas if the
hvar
table was missing. This implements that.I've used skrifa/read_fonts for this since it was already being used for
adjust_axis
and means we don't have to reimplement all the parsing here. This does require transmuting thecoords
from&[i16]
to&[F2Dot14]
, but there are some transmutes like that already in the codebase (e.g. insrc/text/compose.rs
).(Speaking of, which parts of this library are you planning to replace with skrifa?)