Draft: v2.1.0 #364
Open
Draft: v2.1.0 #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add topic entry #330
Co-authored-by: [email protected]
Python Module: -------------- ci: - Support for Azure Pipelines - Split ci pushes to Failure, Success and Production Branch, so that all pipeline pushes can be reviewed before production - Extended Test-protocols in PRs - Improve configurability of model_def by hierarchical defaults - autogenerated files can be marked as such - Results from feature/* branches will be pushed to the corresponding feature/* branch in the target repo, for testing purposes scripts: - phobos convert: Fix for Scenes/Worlds, Args for mesh type and export config core/io: - Refactor utils - Adaption in defaults.json - Several bugfixes in mesh handling - Bugfixes for poses - Configurability for exports has been extended - Enhanced submodel export - Bugfixes for import/export smurf: - Include list of submodels - A mesh collision can now be annotated with primitive collisions, during export the user can decide what to export general: - Several error messages have been improved - Minor codestyle improvements - Updated ROS templates for ROS2 Blender: -------- - Only minor bugfixes - Most bugfixes in Python Module apply here as well ToDo: ----- - Documentation has to be updated accordingly
AlpenAalAlex
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Left comments on:
phobos/ci/base_model.py:948
phobos/utils/misc.py:291
Everything else looks good 👍
| if cwd is None: | ||
| cwd = os.getcwd() | ||
| if not silent: | ||
| log.debug(("Skipping" if dry_run else "Executing") + f": {cmd} in {cwd}") | ||
| if dry_run: | ||
| return "", "" | ||
| proc = subprocess.Popen([cmd], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True, cwd=cwd) | ||
| proc = subprocess.Popen([cmd], stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True, cwd=cwd, executable="/bin/bash") |
There was a problem hiding this comment.
This does not work on Windows. For Windows the code can look like this:
proc = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, shell=True, cwd=cwd)
which changes
[cmd] -> cmd
executable can be omitted or usually C:\Windows\system32\cmd.exe
| readme_content = open(readme_path, "r").read() | ||
| if "Git LFS" not in readme_content: | ||
| with open(readme_path, "a") as readme: | ||
| readme.write(open(resources.get_resources_path("GitLFS_README.md.in")).read()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Python Module:
- Support for Azure Pipelines
- Split ci pushes to Failure, Success and Production Branch, so that all pipeline pushes can be reviewed before production
- Extended Test-protocols in PRs
- Improve configurability of model_def by hierarchical defaults
- autogenerated files can be marked as such
- Results from feature/* branches will be pushed to the corresponding feature/* branch in the target repo, for testing purposes
- phobos convert: Fix for Scenes/Worlds, Args for mesh type and export config
- Refactor utils
- Adaption in defaults.json
- Several bugfixes in mesh handling
- Bugfixes for poses
- Configurability for exports has been extended
- Enhanced submodel export
- Bugfixes for import/export
- Include list of submodels
- A mesh collision can now be annotated with primitive collisions, during export the user can decide what to export
- Several error messages have been improved
- Minor codestyle improvements
- Updated ROS templates for ROS2
Blender:
ToDo:
Related Issues/PRs
#363 #352 #357 #354
Motivation and Context
See Changelog above
How Has This Been Tested?
Types of changes
Checklist: