fix(frontend): remove duplicated ICRC tokens with different index canisters #4411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,12 +43,9 @@ export const icrcChainFusionDefaultTokens: Readable<IcToken[]> = derived( | |||
| /** | |||
| * A flatten list of the default Icrc Ledger and Index canister Ids. | |||
There was a problem hiding this comment.
Can you update this comment?
There was a problem hiding this comment.
right, done!
| @@ -67,8 +65,7 @@ const icrcDefaultTokensToggleable: Readable<IcTokenToggleable[]> = derived( | |||
| ([$icrcDefaultTokens, $icrcUserTokens]) => | |||
| $icrcDefaultTokens.map(({ ledgerCanisterId, indexCanisterId, ...rest }) => { | |||
There was a problem hiding this comment.
Do we still need to destruct the indexCanisterId?
There was a problem hiding this comment.
no, we don't eheh! changed
peterpeterparker
approved these changes
Jan 22, 2025
…with-different-index-canister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There was an issue #4164 , that ICRC tokens that have different index canister (one
undefined), before being added to the codebase, would appear twice after.Since we do not use the index canister ID as way to identify an ICRC token (it can be optional) anymore, we adapt all the checks in the derived stores to compare an ICRC to another ONLY via ledger canister ID.