Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(PocketIC): II canister always belongs to II subnet #4424

Merged
merged 5 commits into from
Mar 19, 2025

Conversation

mraszyk
Copy link
Contributor

@mraszyk mraszyk commented Mar 18, 2025

This PR makes the II canister always belong to the dedicated II subnet (the II canister used to belong to the NNS subnet if no II subnet was specified).

@github-actions github-actions bot added the chore label Mar 18, 2025
@mraszyk mraszyk marked this pull request as ready for review March 18, 2025 20:33
@mraszyk mraszyk requested review from a team as code owners March 18, 2025 20:33
Copy link
Contributor

@bogwar bogwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mraszyk mraszyk added this pull request to the merge queue Mar 19, 2025
Merged via the queue into master with commit 15cc473 Mar 19, 2025
21 checks passed
@mraszyk mraszyk deleted the mraszyk/pic-ii-subnet-split branch March 19, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants