refactor: [EXC-1752] Remove the parts of old CanisterStateBits after migration #4335
+31
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts.proto Co-authored-by: Dimitris Sarlis <dimitrios.sarlis@dfinity.org>
dragoljub-duric
changed the base branch from
master
to
EXC-1752-introduce-canister-state-bits-version-of-task-queue
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
This PR adds `TaskQueue` to `CanisterStateBits`. To keep the change backward compatible, we are adding new optional field tasks of type `TaskQueue` to `pb::CanisterStateBits`. In this PR we are adding support to deserialize both protobuf versions (old and new), while we always serialize with the new one. In the [follow-up](#4335) (planed for the next release) we will remove(reserve) `pb::CanisterStateBits` fields `on_low_wasm_memory_hook_status: pb::OnLowWasmMemoryHookStatus` and `task_queue: pb::VecDequeue` and we will remove deserialization with the old protobuf version. --------- Co-authored-by: Dimitris Sarlis <dimitrios.sarlis@dfinity.org>
Base automatically changed from
EXC-1752-introduce-canister-state-bits-version-of-task-queue
to
master
March 12, 2025 14:53
github-actions
bot
added
@execution
@ic-message-routing-owners
@ic-interface-owners
labels
I would wait until next week when it would be more clear that we don't need to roll back the previous change. There's no reason to risk anything earlier. |
|
I recommend you manually run the nightly tests at some point. The
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow-up on #2254. The plan is to merge this PR after the cutoff for this week's release.