Allow using connector ID as oidc groups prefix #2051
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds prefixes for OIDC groups. I'm not sure if we want to implement this on a different level (middleware?).
But I've been using this for some time and it works fine for my use-case, which is mostly about the security side, not UX.
E.g. it is not possible to configure the exact OIDC prefix with this, but as connector IDs are unique - it makes OIDC groups unique as well. I'm open for discussion if this approach is not how the community would like to solve this. For me, it works and closes the issue #918, therefore, sharing this solution here.
Usage: "Closes #918"
Special notes for your reviewer
Does this PR introduce a user-facing change?
This feature can be enabled with
oidcGroupsPrefix: true
. If this option is missing, it will be disabled by default. So it doesn't require any changes if you're updating from the old version