Support custom context type with generic Ctx
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a `Ctx` type to be specified when creating a `Model` instance so that the context values are type safe. I used `any` instead of typing the `Datastore` types because we aren't using them an they will either be deprecated or revamped in a future release.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
transitive-bullshit
approved these changes
Apr 23, 2024
| @@ -40,7 +39,7 @@ export abstract class AbstractDatastore< | |||
| >; | |||
|
|
|||
| public readonly contentKey: keyof DocMeta; | |||
| public readonly embeddingModel: Model.Embedding.Model; | |||
| public readonly embeddingModel: any; | |||
There was a problem hiding this comment.
the any creep begins 👀 😄
There was a problem hiding this comment.
haha any time i use any, it's a clear sign i'm about to delete that code and couldn't be bothered to fix it 😅
This shows a more realistic and clear way to specify the context generic for a model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a
Ctxtype to be specified when creating aModelinstance so that the context values are type safe.
I used
anyinstead of typing theDatastoretypes because we aren'tusing them an they will either be deprecated or revamped in a future
release.