Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm chart deployment type #2431

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Conversation

arunjaindev
Copy link
Contributor

@arunjaindev arunjaindev commented Jan 31, 2025

default deployment app type for helm chart should be "" if hide helm or gitops is enabled

Fixes https://github.com/devtron-labs/sprint-tasks/issues/1855

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@github-actions github-actions bot added PR:Issue-verification-failed PR:Issue-verification-failed PR:Ready-to-Review PR:Ready-to-Review and removed PR:Issue-verification-failed PR:Issue-verification-failed labels Jan 31, 2025
eshankvaish
eshankvaish previously approved these changes Jan 31, 2025
@arunjaindev arunjaindev merged commit 8251059 into main Jan 31, 2025
9 checks passed
@arunjaindev arunjaindev deleted the fix/helm-chart-deployment-type branch January 31, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR:Ready-to-Review PR:Ready-to-Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants