feat: Runtime Params #2248
Merged
feat: Runtime Params #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohitRaj011
requested review from
vikramdevtron and
vivek-devtron
as code owners
github-actions
bot
added
the
PR:Issue-verification-failed
RohitRaj011
force-pushed
the
feat/runtime-params
branch
from
483f769 to
69f304e
Compare
RohitRaj011
changed the title
eshankvaish
requested changes
Dec 9, 2024
src/components/common/helpers/GitInfoMaterialCard/GitInfoMaterial.tsx
Outdated
Show resolved
Hide resolved
src/components/CIPipelineN/VariableDataTable/VariableDataTable.tsx
Outdated
Show resolved
Hide resolved
src/components/CIPipelineN/VariableDataTable/VariableConfigOverlay.tsx
Outdated
Show resolved
Hide resolved
…pdate, review fixes, code refactor
eshankvaish
previously approved these changes
Dec 9, 2024
… update validations in case of NUMBER format, code refactor
…pyCustomized for overlay
…add global variables to runtime params
…ariables based on format
…-variables feat: runtime params global variables, code refactor
…rict usage of file type for oss
…arent state, optimised validations, various improvements & fixes
…lue and then delete them
…rd into fix/runtime-params
…code optimisation
…ableDataTable - add dot icon when config has changes
fix: runtime params - UAT and QA Fixes
vivek-devtron
previously approved these changes
Dec 16, 2024
fix: VariableDataTable - incorrect check for payload fix
vivek-devtron
approved these changes
Dec 16, 2024
|
github-actions
bot
added
PR:Ready-to-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes https://github.com/devtron-labs/sprint-tasks/issues/1187
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: