Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace select v4 #2061

Merged
merged 53 commits into from
Oct 7, 2024
Merged

feat: replace select v4 #2061

merged 53 commits into from
Oct 7, 2024

Conversation

shivani170
Copy link
Contributor

@shivani170 shivani170 commented Sep 17, 2024

#Description

  • App Details > Environment

  • EnvironmentList.tsx

    • 1. Sidebar => Job > Trigger job > Excute job in
      Image

    • 2. ciMaterial.tsx => CI pipeline.tsx > Jobs > Configuration > Createjob > Sidebar > Execute tasks in environment
      Image

-[x] ciCreateDockerFileOption.tsx => Create DockerFile
Screenshot 2024-09-30 at 4 08 01 PM

  • CIBuildpackBuildOptions => Select DockerFile

    • Select repository containing code
    • Language
    • Version.
  • ciConfig > CreateDockerFileLanguageOptions.tsx

  • BuildContext

    • Select repo containing build contex
    • Build Context Path (Relative)
  • ChartValueEditor.tsx
    Image

  • EnvConfigurationNAv

    • App Group > configuration > Application => ApplicationRoutes.tsx
    • Image
    • Devtron Apps > configuration > Application => AppNavigations.tsx
    • Image
  • EnvironmentOverrideRouter.tsx

    • Job > configuration > Add environment
    • Image
  • [x[ ExpirationDate > API Token

  • LinkedCIDetail Modal > Environment


Existing Bugs:

  1. Devtron/Helm App Details page:
Screenshot 2024-10-01 at 3 42 25 PM 2. [x] Min Size reduces to 56px from 100px > assignment operator in task Screenshot 2024-10-01 at 3 45 23 PM

--------------------------------------Targeted area------------------------------------------------------------

Image


Fixes https://github.com/devtron-labs/sprint-tasks/issues/851

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@shivani170 shivani170 changed the base branch from develop to feat/replace-select-picker-v3 September 18, 2024 10:12
@shivani170 shivani170 changed the title Feat/replace select v4 feat: replace select v4 Sep 18, 2024
Base automatically changed from feat/replace-select-picker-v3 to develop September 20, 2024 12:13
@shivani170 shivani170 self-assigned this Sep 30, 2024
RohitRaj011
RohitRaj011 previously approved these changes Oct 4, 2024
vivek-devtron
vivek-devtron previously approved these changes Oct 7, 2024
Copy link

sonarqubecloud bot commented Oct 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@shivani170 shivani170 merged commit a1ce16e into develop Oct 7, 2024
4 of 6 checks passed
@shivani170 shivani170 deleted the feat/replace-select-v4 branch October 7, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants