#404: enhance logging with custom slf4j bridge #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/cli/Ideasy.java
renamed TestLogger to IdeLoggerAdapter added missing param to javadoc renamed TestProvider to TestProviderImpl renamed TestLoggerFactory to TestLoggerFactoryImpl
added first implementations for IdeLoggerAdapter methods replaced IdeSubLoggerSlf4j with IdeSubLoggerOut
added null checks to IdeLoggerAdapter debug methods
added rest of null checks
# Conflicts: # cli/pom.xml # cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
Collaborator
Pull Request Test Coverage Report for Build 18478663135Details
💛 - Coveralls |
# Conflicts: # .github/workflows/update-urls.yml # cli/pom.xml # url-updater/pom.xml # url-updater/src/main/java/com/devonfw/tools/ide/url/updater/AbstractUrlUpdater.java
hohwille
reviewed
Apr 28, 2025
cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Apr 28, 2025
cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
Outdated
Show resolved
Hide resolved
hohwille
reviewed
Apr 28, 2025
Member
|
Comming to the really interesting questions for the review:
|
Member
Ah, question was already answered by the CI build that fails:
Yes, this is required to make it work. |
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java
set loggingContext to private added getter for loggingContext added check to ignore WireMock specific log messages removed logback-classic from dependencies
jan-vcapgemini
added
the
internal
# Conflicts: # cli/src/main/java/com/devonfw/tools/ide/context/AbstractIdeContext.java # gui/src/main/java/com/devonfw/ide/gui/MainController.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #404
Continues PR: #760 by @KianRolf
Implements:
com.devonfw.ide.tools.urlintourl-updatermodule (kept package names)WireMockdependency from 2.35.2 to 3.11.0jackson-coredependency toide-cliurlnamespace totoolsLogbackServiceProviderto url-updater serviceIdeLoggerAdapter(bridge class for slf4j)