Avoid Castle's default trace logging#1673
Open
Youssef1313 wants to merge 2 commits intodevlooped:mainfrom
Open
Avoid Castle's default trace logging#1673Youssef1313 wants to merge 2 commits intodevlooped:mainfrom
Youssef1313 wants to merge 2 commits intodevlooped:mainfrom
Conversation
Author
|
Trace logging being enabled looks like a Castle bug in the first place, specific to .NET Framework. castleproject/Core#745 is a proposed fix. Whether or not you would consider disabling the logging completely by default is up to you, and also very much depends on the outcome of castleproject/Core#745. |
Youssef1313
commented
May 4, 2026
Comment on lines
+37
to
+40
| this.generator = new ProxyGenerator() | ||
| { | ||
| Logger = NullLogger.Instance, | ||
| }; |
Author
There was a problem hiding this comment.
An alternative here might be (this.generator.Logger as TraceLogger)?.Level = LoggerLevel.Warn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Castle's trace logging can have severe perf impact as the log operations are all locking, so it can slow down significantly test runs that are parallelized.