Deduplicate project properties before generation

Avoids build failures due to misconfiguration. Closes #172
devlooped · Jan 28, 2023 · 0f01535 · 0f01535
1 parent 1eb951d
commit 0f01535
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/ThisAssembly.Project/ThisAssembly.Project.targets b/src/ThisAssembly.Project/ThisAssembly.Project.targets
@@ -8,8 +8,11 @@
 
   <Target Name="InjectThisAssemblyProject" DependsOnTargets="$(InjectThisAssemblyProjectDependsOn)" 
           BeforeTargets="PrepareForBuild;CompileDesignTime;GenerateMSBuildEditorConfigFileShouldRun">
+    <ItemGroup>
+      <ProjectPropertyDistinct Include="@(ProjectProperty -> Distinct())" />
+    </ItemGroup>
     <PropertyGroup>
-      <ThisAssemblyProject>@(ProjectProperty, '|')</ThisAssemblyProject>
+      <ThisAssemblyProject>@(ProjectPropertyDistinct, '|')</ThisAssemblyProject>
     </PropertyGroup>
     <ItemGroup Condition="'$(ThisAssemblyProject)' != ''">
       <CompilerVisibleProperty Include="@(ProjectProperty)" />

diff --git a/src/ThisAssembly.Tests/ThisAssembly.Tests.csproj b/src/ThisAssembly.Tests/ThisAssembly.Tests.csproj
@@ -49,6 +49,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <ProjectProperty Include="Foo" />
     <ProjectProperty Include="Foo" />
     <Constant Include="Foo.Bar" Value="Baz" Comment="Yay!" />
     <Constant Include="Foo.Hello" Value="World" Comment="Comments make everything better 😍" />