build(npm): automatically run build-icons for correct os #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReenigneArcher
force-pushed
the
build/npm/automatically-run-build-icons-for-correct-os
branch
from
52ebb09 to
c94da43
Compare
|
I opened a bug report in npm for the venv issue. I think this would technically affect the unix commands as well so it's probably not necessary to wait for this to be resolved. But, I do have an idea on how to detect if we are running in an activated venv which I will work on shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double check these details before you open a PR
Features
This PR makes it so
npm run build-iconsworks on all standard OSes.This PR closes NONE
Notes
A new dev dependency was added to simplify this: https://www.npmjs.com/package/run-script-os
Edit: This is draft as I discovered it is not using the activated python venv. Will update once resolved.