Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: track component clicks and chats by component name #3432

Merged
merged 3 commits into from
Feb 26, 2025
Merged

feature: track component clicks and chats by component name #3432

merged 3 commits into from
Feb 26, 2025
+176 −138

Conversation

cdxker
Copy link
Member

@cdxker cdxker commented Feb 25, 2025

Copy of #3429

Requesting changes, this seems to cause a react load error on initial mount

image

@skeptrunedev skeptrunedev force-pushed the ds/add-component-analytics branch from 1cd644c to a375fed Compare February 25, 2025 23:32
@skeptrunedev skeptrunedev force-pushed the ds/add-component-analytics branch from a375fed to 256f192 Compare February 25, 2025 23:34
@skeptrunedev skeptrunedev force-pushed the ds/add-component-analytics branch from 256f192 to c3d2b44 Compare February 25, 2025 23:50
skeptrunedev
skeptrunedev requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to completely break the component:

analytics-break-component.mp4

skeptrunedev
skeptrunedev requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Analytics event when I open the component seems to error

skeptrunedev
skeptrunedev approved these changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@skeptrunedev skeptrunedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Will not block merge, but it would be nice if I could see the details of the event here for which variant of the component got opened.

@skeptrunedev skeptrunedev merged commit f6231a8 into main Feb 26, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skeptrunedev skeptrunedev skeptrunedev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdxker @skeptrunedev @densumesh