Typescript definitions for Preact > 8.2.8 & Redux > 4.0 & Typescript > 2.8 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please merge, I've wasted 3 hours to solve that, eventually downgraded to redux 3 & preact-redux 1.X helped. |
|
I merged #30 and #33 prior to peeking at this PR, and they overlapped quite a bit. I've tried to sort out the merge conflicts, but would you be able to double-check @sameergoyal? Sorry for the delay! I'm open to adding collaborators on this project if anyone has the time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest versions of Preact, Redux & Typescript cause a bunch of errors in the typings file for preact-redux.
This PR includes the fixes required for all of them.