Added variable os_immutable_fs to oshardening #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able filesystems, in particular ostree systems. Updated oshardening/README.md to reflect this Signed-off-by: James Miller <[email protected]>
|
woot! I think this might work. I made all the changes you request, hope its ok. |
|
superseeds #666 |
|
I am totally new to molecule, but need to learn it to write tests for my roles. I am guessing that coreos or similar needs to be added to the list of distros and a conditional check in molecule when testing os_immutable_fs... Molecule for the next week or so for me, until I can write tests for my own projects, and then I can see if I can make sense of this ... |
Signed-off-by: James Miller <[email protected]>
|
I just added a check that was missing from my initial commit, which I didn't pick up on until I used the os_immutable_fs branch in my code. |
Signed-off-by: James Miller <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to compensate for immutable filesystems, in particular ostree systems. Updated oshardening/README.md to reflect this
Signed-off-by: James Miller [email protected]