Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next.js 11 webpack 5 eslint prettier #482

Merged
merged 3 commits into from
Jun 28, 2021

Conversation

Digital-Coder
Copy link
Contributor

Major Changes:

react.js 16.12 ->17.0.2
next.js 10.2 ->11.0.1

Minor Changes:

enforced reactStrictMode. It is only in dev environment and you can read it more about it here:
what is strict mode ?

removed unnecessary packages:

webpack (next has internally)
postcss (there is no postcss.config)
@types/node-sass (there is no typescript)

solved conflicts

Apparently package "natural" has missing internal packages and webpack 5 will not let it bundle.
All I had to do is to switch with "pluralize" and "idea generation button" is working as usual.

"next-images" package is conflicting now with internal static imports feature, but I applied
solution from their github repository and it should behave as usual. reference

@Digital-Coder Digital-Coder changed the base branch from master to in-progress June 23, 2021 18:02
@Digital-Coder
Copy link
Contributor Author

Update

Added eslint and prettier.

You need to install eslint extention and restart vscode
If you run " npm run lint " it should show you potential errors
if you CTRL + S in a file it should fix small bugs and format a file
if you run "npm run prettier " it should format all files in a codebase
It also has to show errors/ warnings in a vscode console

I tried it on my own and it has been working, but testing is necessary
because there could be some conflicts with coders own vscode .settings.json

Capture2

@Digital-Coder Digital-Coder changed the title upgraded to next.js 11 and webpack 5 next.js 11 webpack 5 eslint prettier Jun 24, 2021
@Enjoy2Live Enjoy2Live changed the base branch from in-progress to next-11 June 28, 2021 00:17
Copy link
Member

@Enjoy2Live Enjoy2Live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Digital-Coder, the PR looks good and I don't see many errors with it. I'd say this is the best PR I've ever reviewed!

I'm right now extending the es-lint functionality to work with committed files only.

@Enjoy2Live Enjoy2Live merged commit b477e6f into dev-launchers:next-11 Jun 28, 2021
@dev-launchers-flux
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants