Remove line separator detection logic #7251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7251 +/- ##
============================================
- Coverage 84.75% 84.74% -0.01%
Complexity 3996 3996
============================================
Files 577 577
Lines 12133 12126 -7
Branches 2486 2483 -3
============================================
- Hits 10283 10276 -7
Misses 624 624
Partials 1226 1226 ☔ View full report in Codecov by Sentry. |
|
@3flex is this ready for review? |
|
I messed up from mobile and I can move it back to draft |
This is now full handled by the IntelliJ components in the embeddable compiler.
cortinico
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now fully handled by the IntelliJ components in the embeddable compiler.