Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do Not Merge] redirect after success #504

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asafshen
Copy link
Member

@asafshen asafshen commented Jul 1, 2024

Related Issues

✅ Fixes <link_to_github_issue>

Description

Just a demo for a discussion purpose

Copy link

vercel bot commented Jul 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-hosting ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:53am
auth-hosting-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:53am
auth-hosting-euc1 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:53am
auth-hosting-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:53am
auth-hosting-sandbox-us ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 9:53am

// redirect after success if there is redirect-after-success query param
const redirectAfterSuccess = urlParams.get('redirect-after-success');
if (redirectAfterSuccess) {
window.location.assign(redirectAfterSuccess);

Check warning

Code scanning / CodeQL

Client-side URL redirect Medium

Untrusted URL redirection depends on a
user-provided value
.
// redirect after success if there is redirect-after-success query param
const redirectAfterSuccess = urlParams.get('redirect-after-success');
if (redirectAfterSuccess) {
window.location.assign(redirectAfterSuccess);

Check failure

Code scanning / CodeQL

Client-side cross-site scripting High

Cross-site scripting vulnerability due to
user-provided value
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant