Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close model (multilogin) #44

Open
wants to merge 1 commit into
base: multilogin
Choose a base branch
from
Open

Conversation

ovvn
Copy link
Member

@ovvn ovvn commented Apr 4, 2022

model.close = function (cb) {
  cb = this.wrapCallback(cb);
  var model = this;
  this.whenNothingPending(function() {
    model.root.socket.close();
    cb();
  });
}

In some places were we create a model from a backend manually we leave an opened socket. This PR closes open socket connections in the places.

@ovvn ovvn changed the title Close model Close model (multilogin) Apr 4, 2022
@ovvn ovvn requested review from cray0000, fctsvirus, MaestroSc2, vmakhaev, a team and Yska April 6, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants