ensure kubeclient ns is release ns for helm actions

[thorbenbelow]

Fixes #2634

Also looks like this is the same issue as with #1033

From my understanding helm will use the namespace from flags to determine where it runs actions. Imo this should always be the release namespace.

[derailed]

@thorbenbelow Thank you for this update Thornben!

[thorbenbelow]

Hi @derailed, unfortunately I'm not too familiar with k9s' and Helms' codebase, so I've just been trying to orient myself on how helm constructs their client.

Just to be clear: You are suggesting to do this instead?

Suggested change

	func ensureHelmConfig(flags *genericclioptions.ConfigFlags, ns string) (*action.Configuration, error) {
	settings := &genericclioptions.ConfigFlags{
	Namespace: &ns,
	Context: flags.Context,
	BearerToken: flags.BearerToken,
	APIServer: flags.APIServer,
	CAFile: flags.CAFile,
	KubeConfig: flags.KubeConfig,
	Impersonate: flags.Impersonate,
	Insecure: flags.Insecure,
	TLSServerName: flags.TLSServerName,
	ImpersonateGroup: flags.ImpersonateGroup,
	WrapConfigFn: flags.WrapConfigFn,
	}
	cfg := new(action.Configuration)
	func ensureHelmConfig(flags *genericclioptions.ConfigFlags, ns string) (*action.Configuration, error) {
	settings := &genericclioptions.ConfigFlags{
	Namespace: &ns,
	}
	cfg := new(action.Configuration)

[derailed]

@thorbenbelow nw Thank you Thorben! right I think flags.Namespace = &ns should be all we need.

[thorbenbelow]

I see what you mean. However, in this case usePersistentConfig must be false. Would you still prefer that over copying the config for helm operations?

There is also a PR in helm that should fix this issue as well. Not sure if that gets merged any time soon though.

[derailed]

@thorbenbelow Thank you Thorben! I think the core issue here is helm does not use the passed in ns and create their own api client via a factory. Let's keep your original impl for the time being and make a copy of the flags prior to calling the helm api which I think is the safest course of action.

[thorbenbelow]

Sorry for the late reply. I squashed my changes and rebased.
Do we need tests for this or is there anything else needed to make this PR mergeable?