드랍유도 컨텐츠 수정 작업 #299
Open
드랍유도 컨텐츠 수정 작업 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendoei
force-pushed
the
RecommendSearchKeyword
branch
from
9622bca
to
fe41c5d
Compare
thoonk
approved these changes
Nov 5, 2024
|
|
||
| import UIKit | ||
|
|
||
| class GuideDetailView: UIView { |
There was a problem hiding this comment.
Suggested change
| class GuideDetailView: UIView { | |
| final class GuideDetailView: UIView { |
| import RxSwift | ||
| import SnapKit | ||
|
|
||
| class RecommendHeaderView: UICollectionReusableView { |
There was a problem hiding this comment.
Suggested change
| class RecommendHeaderView: UICollectionReusableView { | |
| final class RecommendHeaderView: UICollectionReusableView { |
|
|
||
| import Kingfisher | ||
|
|
||
| class RecommendKeywordCell: UICollectionViewCell { |
There was a problem hiding this comment.
Suggested change
| class RecommendKeywordCell: UICollectionViewCell { | |
| final class RecommendKeywordCell: UICollectionViewCell { |
Comment on lines
+117
to
+122
| Observable.merge( | ||
| self.backButton.rx.tap.asObservable() | ||
| ) | ||
| .bind { _ in | ||
| self.navigationController?.popViewController(animated: true) | ||
| } |
There was a problem hiding this comment.
Suggested change
| Observable.merge( | |
| self.backButton.rx.tap.asObservable() | |
| ) | |
| .bind { _ in | |
| self.navigationController?.popViewController(animated: true) | |
| } | |
| self.backButton.rx.tap | |
| .bind(with: self) { owner, _ in | |
| owner.navigationController?.popViewController(animated: true) | |
| } |
| @@ -18,39 +18,47 @@ protocol SearchingMusicViewModel: ViewModel { | |||
|
|
|||
| final class DefaultSearchingMusicViewModel: SearchingMusicViewModel { | |||
| private let model: SearchMusicUsecase | |||
There was a problem hiding this comment.
Suggested change
| private let model: SearchMusicUsecase | |
| private let searchMusicUseCase: SearchMusicUsecase |
Comment on lines
+146
to
+149
| await self.model.deleteRecentSearch(keyword: keyword) | ||
|
|
||
| do { | ||
| let recentQueries = try await self.model.getRecentSearches().value |
There was a problem hiding this comment.
Suggested change
| await self.model.deleteRecentSearch(keyword: keyword) | |
| do { | |
| let recentQueries = try await self.model.getRecentSearches().value | |
| await self.searchMusicUseCase.deleteRecentSearch(keyword: keyword) | |
| do { | |
| let recentQueries = try await self.searchMusicUseCase.getRecentSearches().value |
| self.location = location | ||
| } | ||
|
|
||
| func convert(input: Input, disposedBag: DisposeBag) -> Output { | ||
| let output = Output() | ||
|
|
||
| input.viewDidAppearEvent | ||
| input.viewDidLoadEvent | ||
| .subscribe(onNext: { [weak self] in | ||
| self?.model.getRecentSearches() |
There was a problem hiding this comment.
Suggested change
| self?.model.getRecentSearches() | |
| self?. searchMusicUseCase.getRecentSearches() |
| input.keywordQueryDidPressEvent | ||
| .bind { [weak self] keywordQuery in | ||
| self?.searchMusic(output: output, keyword: keywordQuery) | ||
| self?.model.saveRecentSearch(keyword: keywordQuery) |
There was a problem hiding this comment.
Suggested change
| self?.model.saveRecentSearch(keyword: keywordQuery) | |
| self?.searchMusicUseCase.saveRecentSearch(keyword: keywordQuery) |
|
|
||
| import SnapKit | ||
|
|
||
| class RecentSearchesHeaderView: UICollectionReusableView { |
There was a problem hiding this comment.
Suggested change
| class RecentSearchesHeaderView: UICollectionReusableView { | |
| final class RecentSearchesHeaderView: UICollectionReusableView { |
Comment on lines
+19
to
+21
| let titleLabel = UILabel() | ||
| let arrowIconImageView = UIImageView() | ||
| let infoIconButton = UIButton() |
There was a problem hiding this comment.
Suggested change
| let titleLabel = UILabel() | |
| let arrowIconImageView = UIImageView() | |
| let infoIconButton = UIButton() | |
| private let titleLabel = UILabel() | |
| private let arrowIconImageView = UIImageView() | |
| private let infoIconButton = UIButton() |
joseph704
approved these changes
Nov 18, 2024
| func getMostDroppedMusicList() -> Single<[Music]> | ||
| func getArtistList() -> Single<[Artist]> | ||
| func getPromptOfTheDay() -> Single<String?> | ||
| func getRecommendSections() -> Single<[RecommendSectionDTO]> |
There was a problem hiding this comment.
UseCase에서 네트워크 통신 DTO를 반환하도록 되어있는데,
혹시 DTO에 의해 매핑된 Entity를 두고 반환하게 하는 게 어떨까요??
DTO가 변경되도 Entity를 바라보는 Presentation Layer에선 변경점이 없도록 하면 유지보수성이 올라갈 것 같아서요! @thoonk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 드랍유도 컨텐츠 수정
open #298
내용
스크린샷