Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_throw check to CLI running #3725

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add no_throw check to CLI running #3725

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Component/ProcessRunner/ProcessRunner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,19 @@
$process->setWorkingDirectory($config['cwd']);
}

try {

Check failure on line 72 in src/Component/ProcessRunner/ProcessRunner.php

View workflow job for this annotation

GitHub Actions / phpstan 

Method Deployer\Component\ProcessRunner\ProcessRunner::run() should return string but return statement is missing.
$process->mustRun($callback);
return $process->getOutput();
} catch (ProcessFailedException $exception) {
throw new RunException(
$host,
$command,
$process->getExitCode(),
$process->getOutput(),
$process->getErrorOutput()
);
if (!$config['no_throw']) {
antonmedv marked this conversation as resolved.
Show resolved Hide resolved
throw new RunException(
$host,
$command,
$process->getExitCode(),
$process->getOutput(),
$process->getErrorOutput()
);
}
} catch (ProcessTimedOutException $exception) { // @phpstan-ignore-line can be thrown but is absent from the phpdoc
throw new TimeoutException(
$command,
Expand Down
Loading