fix WSL "connection refused" to the fake API #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
approved these changes
Apr 26, 2024
|
@RobJellinghaus if you have a free moment, could you verify that this works in WSL without having to use the FAKE_API_HOST environment variable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the CLI starts a fake API server which intercepts calls to a real API which allows the CLI to print output to stdout or a file.
Unfortunately on Linux, Docker won't allow a container to communicate with a server running on the host on 127.0.0.1, so we had to set it to 0.0.0.0.
Even more unfortunate, is on WSL which is a Linux variant, 0.0.0.0 doesn't work at all so we have to set it back to 127.0.0.1.
Using the info in microsoft/WSL#423 (comment) to detect WSL.