-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form Upload README #34689
base: main
Are you sure you want to change the base?
Form Upload README #34689
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same feedback here as in this other PR: https://github.com/department-of-veterans-affairs/vets-api/pull/20794/files#r1956304237
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, one minor suggestion
|
||
The Form Upload tool launched with support for four forms: `21-0779`, `21-509`, `21P-0518-1`, and `21P-0516-1`. If you'd like to add support for additional forms, follow the steps below. | ||
|
||
1. Follow the instructions in the `vets-api` repo to add support from the back end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will users know where to look for this? It's not clear to me on how much work this is, like is it "toggle a thing and done", or if this is needing to flesh out and entire backend support for a form. Maybe good if a product person could read this and have an idea of how much work it is.
Summary
This PR adds a README for the Form Upload tool, specifically about how to add more forms to the tool.
Related issue(s)
https://github.com/orgs/department-of-veterans-affairs/projects/1443/views/3?sliceBy%5Bvalue%5D=Thrillberg&pane=issue&itemId=93337305&issue=department-of-veterans-affairs%7CVA.gov-team-forms%7C1969