API-35477-526-snyc-service-extraction

[stiehlrod]

Summary

• Adds service for pdf generation
• Adds service for docker container uploads
• Adds private methods needed for a successful response. Tested with Postman.

Related issue(s)

• API-36597

Testing done

• New code is covered by unit tests
• Tested with Postman

1. Settings.evss.mock_claims: false
2. Settings.claims_api.benefits_documents.use_mocks: false
3. test users
   • Jerry Brooks, 1012830245V504544, 796148937
   • Chad Barrett, 1012853277V552077, 796263749
   • Jesse Gray, 1012666073V986297, 796378881
   • Jeff Watson, 1012845703V609890, 796246757

What areas of the site does it impact?

modified:   modules/claims_api/app/services/claims_api/disability_compensation/pdf_generation_service.rb
modified:   modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modified:   modules/claims_api/app/services/claims_api/disability_compensation/docker_container_service.rb
modified:   modules/claims_api/app/services/claims_api/service.rb
modified:   modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb
modified:   modules/claims_api/app/controllers/claims_api/v2/application_controller.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 283 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/claims_api/app/controllers/claims_api/v2/veterans/disability_compensation_controller.rb (+44/-2) modules/claims_api/app/services/claims_api/disability_compensation/docker_container_service.rb (+34/-0) modules/claims_api/app/services/claims_api/disability_compensation/pdf_generation_service.rb (+78/-0) modules/claims_api/app/services/claims_api/service.rb (+32/-0) modules/claims_api/lib/custom_error.rb (+1/-1) modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+0/-2) modules/claims_api/spec/services/disability_compensation/docker_container_service_spec.rb (+43/-0) modules/claims_api/spec/services/disability_compensation/pdf_generation_service_spec.rb (+46/-0) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[FonzMP]