Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MHV helpdesk information toggle #16777

Merged
merged 3 commits into from
May 20, 2024
Merged

Conversation

carlosfelix2
Copy link
Contributor

Summary

  • Added MHV helpdesk information feature toggle

Related issue(s)

department-of-veterans-affairs/va.gov-team#79333

@carlosfelix2 carlosfelix2 self-assigned this May 16, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to cfelix/79333-helpdek-info/main/main May 16, 2024 15:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to cfelix/79333-helpdek-info/main/main May 16, 2024 16:43 Inactive
Copy link
Contributor

@dcloud dcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include the phrase "on MHV-on-VA.gov Landing Page " in the description to clarify where the toggle is used?

@@ -697,6 +697,9 @@ features:
mhv_transitional_medical_records_landing_page:
actor_type: user
description: Enables the transitional Medical Records page at /my-health/records
mhv_helpdesk_information_enabled:
actor_type: user
description: Enables the MHV helpdesk information
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: Enables the MHV helpdesk information
description: Enables the MHV helpdesk information on MHV-on-VA.gov Landing Page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I left it without that to leave it open for other apps to use it since the gate is the existence of the MHV helpdesk. So, instead of having a feature toggle for each app, we could have one for the MHV helpdesk.

@carlosfelix2 carlosfelix2 marked this pull request as ready for review May 17, 2024 17:17
@carlosfelix2 carlosfelix2 requested review from a team as code owners May 17, 2024 17:17
@carlosfelix2 carlosfelix2 merged commit 80c6785 into master May 20, 2024
19 checks passed
@carlosfelix2 carlosfelix2 deleted the cfelix/79333-helpdek-info branch May 20, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants