Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug/10241 Android Text Collision with claims history #10401

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

bug/10241 Android Text Collision with claims history #10401

wants to merge 1 commit into from

Conversation

ATeal
Copy link
Contributor

@ATeal ATeal commented Jan 10, 2025

Description of Change

Pretty simple change, changes the text wrap threshhold for the header banner so that it wraps a few lengths sooner.

for #10241

Screenshots/Video

Before:
image
After:
image

Testing

  • Tested on iOS
  • Tested on Android

Reviewer Validations

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@ATeal ATeal requested review from a team as code owners January 10, 2025 12:59
@ATeal ATeal mentioned this pull request Jan 10, 2025
Open
5 tasks
matt-guest-wilcore
matt-guest-wilcore reviewed Jan 23, 2025
View reviewed changes
VAMobile/src/components/Templates/HeaderBanner.tsx
@@ -84,7 +84,7 @@ const HeaderBanner: FC<HeaderBannerProps> = ({
useFocusEffect(focus === 'Title' ? setFocusTitle : setFocus)
const screenReaderEnabled = useIsScreenReaderEnabled()

const TEXT_CONSTRAINT_THRESHOLD = 30
const TEXT_CONSTRAINT_THRESHOLD = 26
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably fine but did you test on smaller screen sizes?

kimmccaskill-oddball
kimmccaskill-oddball approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@kimmccaskill-oddball kimmccaskill-oddball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as matts question was answered!

@github-actions github-actions bot added the FE-With QA A PR waiting for QA Activity label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-guest-wilcore matt-guest-wilcore matt-guest-wilcore left review comments

@kimmccaskill-oddball kimmccaskill-oddball kimmccaskill-oddball approved these changes

@timwright12 timwright12 Awaiting requested review from timwright12 timwright12 is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@alexandec alexandec Awaiting requested review from alexandec alexandec is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@theodur theodur Awaiting requested review from theodur theodur is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@dumathane dumathane Awaiting requested review from dumathane dumathane is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@cadibemma cadibemma Awaiting requested review from cadibemma cadibemma is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@Sparowhawk Sparowhawk Awaiting requested review from Sparowhawk Sparowhawk is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

@DonMcCaugheyUSDS DonMcCaugheyUSDS Awaiting requested review from DonMcCaugheyUSDS DonMcCaugheyUSDS is a code owner automatically assigned from department-of-veterans-affairs/flagship-mobile-reviewers

Assignees
No one assigned
Labels
FE-With QA A PR waiting for QA Activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ATeal @kimmccaskill-oddball @matt-guest-wilcore