Updating icon sizing and color based on UX feedback

department-of-veterans-affairs · Feb 14, 2025 · 99424ed · 99424ed
1 parent 0423f0f
commit 99424ed
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/VAMobile/src/components/BaseListItem.tsx b/VAMobile/src/components/BaseListItem.tsx
@@ -109,7 +109,7 @@ export const ButtonDecorator: FC<{
     case ButtonDecoratorType.Switch:
       return <SwitchComponent onPress={switchOnPress} {...decoratorProps} />
     case ButtonDecoratorType.SelectedItem:
-      return <Icon name={'Check'} height={13} width={16} fill={theme.colors.icon.pickerIcon} />
+      return <Icon name={'Check'} height={18} width={18} fill={theme.colors.icon.pickerIcon} />
     case ButtonDecoratorType.Delete:
       return <Icon name={'Delete'} height={16} width={14} fill={theme.colors.icon.error} />
     case ButtonDecoratorType.RadioFilled:

diff --git a/VAMobile/src/components/LinkWithAnalytics.tsx b/VAMobile/src/components/LinkWithAnalytics.tsx
@@ -70,7 +70,7 @@ const LinkWithAnalytics = ({ analyticsOnPress, analyticsProps, disablePadding, .
       return <TextView>ERROR: Type "attachment" not supported with useOldLinkComponent enabled</TextView>
     } else if (props.type === 'call TTY') {
       linkType = 'callTTY'
-    } else if (props.type === 'custom') {
+    } else if (props.type === 'url') {
       linkType = 'externalLink'
     } else {
       linkType = props.type

diff --git a/VAMobile/src/utils/secureMessaging.tsx b/VAMobile/src/utils/secureMessaging.tsx
@@ -5,6 +5,7 @@ import { Asset, launchCamera, launchImageLibrary } from 'react-native-image-pick
 import { ImagePickerResponse } from 'react-native-image-picker/src/types'
 
 import { IconProps } from '@department-of-veterans-affairs/mobile-component-library'
+import { colors } from '@department-of-veterans-affairs/mobile-tokens'
 import { ActionSheetOptions } from '@expo/react-native-action-sheet'
 import { TFunction } from 'i18next'
 import _ from 'underscore'
@@ -50,6 +51,8 @@ export const getMessagesListItems = (
     const isSentFolder = folderName === FolderNameTypeConstants.sent
     const isDraftsFolder = folderName === FolderNameTypeConstants.drafts
     const isOutbound = isSentFolder || isDraftsFolder
+    const attachFileIconColor =
+      theme.mode === 'dark' ? colors.vadsColorFormsBorderDefaultOnDark : colors.vadsColorFormsBorderDefaultOnLight
     const unreadIconProps =
       readReceipt !== READ && !isOutbound
         ? ({ svg: Unread, height: 16, width: 16, testID: 'Unread' } as IconProps)
@@ -58,9 +61,9 @@ export const getMessagesListItems = (
       hasAttachments || attachment
         ? ({
             name: 'AttachFile',
-            width: 16,
-            height: 16,
-            fill: theme.colors.background.bullet,
+            width: 24,
+            height: 24,
+            fill: attachFileIconColor,
             testID: 'AttachFile',
           } as IconProps)
         : undefined