Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yq support #4861

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add yq support #4861

wants to merge 4 commits into from

Conversation

axhav
Copy link

@axhav axhav commented Nov 12, 2024

Hi!
This is pull requests adds support for the yq (https://github.com/mikefarah/yq) yaml command line processor.
Its a tool written in go, with similar functionallity to jq, so its nice to have on dependency restricted platforms.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a tests for the Handle method. Good example would be test/handler/test_jq_handler.vader

g:ale_yaml_yq_executable *g:ale_yaml_yq_executable*
*b:ale_yaml_yq_executable*
Type: |String|
Default: `'gll'`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look right? should this be yq instead of gll?

Type: |String|
Default: `''`

This variable can be set to pass additional options to gll.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, should this be yq instead of gll?


This variable can be set to pass additional options to gll.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about g:ale_yaml_yq_filters? would be nice to document it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants