Skip to content

Conversation

@axhav
Copy link
Contributor

@axhav axhav commented Nov 12, 2024

Hi!
This is pull requests adds support for the yq (https://github.com/mikefarah/yq) yaml command line processor.
Its a tool written in go, with similar functionallity to jq, so its nice to have on dependency restricted platforms.

Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a tests for the Handle method. Good example would be test/handler/test_jq_handler.vader

ntumbuka and others added 9 commits December 18, 2024 22:34
…e-analysis#4865)

Python fixers and linters were failing when vim is running in a virtual
environment that's located in a path containing text `poetry`. The cause
of this was the regular expression `poetry\|pipenv\|uv$` which matches
`poetry` and `pipenv` if they appear anywhere in the virtualenv path.
…4858)

Actionlint supports a config file and it lives in a very searchable
path, as the only files it acts on are in the `.github` directory
already.

Look for an `actionlint.yml` and `.yaml` in that path, and use the
config if its there.
With the 1.6 version of jq the error message start with "parse error".
With the last version of jq the error message start with "jq: parse error".
Fix it by using a regular expression that works in both cases.
…analysis#4867)

end_line_no/end_line_pos are optional. Example SQL:
`SELECT NULL FROM {{ a_jinja_templated_table }};`

`sqlfluff lint --dialect ansi --format json` gives the following error
among others:
```
{"start_line_no": 1, "start_line_pos": 21, "code": "TMP", "description":
"Undefined jinja template variable: 'a_jinja_templated_table'", "name":
"", "warning": false}
```

As one can see there is no end_line_no/end_line_pos.
@axhav
Copy link
Contributor Author

axhav commented Dec 20, 2024

Hey, sorry for taking some time. I've updated the PR, removed the copy-paste errors and added a test case, care to take a new look.

@axhav axhav requested a review from hsanson December 24, 2024 12:40
Copy link
Contributor

@hsanson hsanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@hsanson hsanson merged commit e82fd24 into dense-analysis:master Dec 29, 2024
7 checks passed
@axhav axhav deleted the add-yq-support branch January 8, 2025 15:29
cyyever pushed a commit to cyyever/ale that referenced this pull request Mar 24, 2025
* Added jq support

Cleaned up yq.vim file

* Updated docs

* Updated supported-tools.md

* Added yq tests

* Fix python linting/formatting error when in virtual environment (dense-analysis#4865)

Python fixers and linters were failing when vim is running in a virtual
environment that's located in a path containing text `poetry`. The cause
of this was the regular expression `poetry\|pipenv\|uv$` which matches
`poetry` and `pipenv` if they appear anywhere in the virtualenv path.

* Add cljfmt fixer for clojure files (dense-analysis#4860)

* When using `actionlint` look for & use a config file (dense-analysis#4858)

Actionlint supports a config file and it lives in a very searchable
path, as the only files it acts on are in the `.github` directory
already.

Look for an `actionlint.yml` and `.yaml` in that path, and use the
config if its there.

* Fix linting with jq (dense-analysis#4765) (dense-analysis#4862)

With the 1.6 version of jq the error message start with "parse error".
With the last version of jq the error message start with "jq: parse error".
Fix it by using a regular expression that works in both cases.

* Properly handle optional end_line_no/end_line_pos in sqlfluff (dense-analysis#4867)

end_line_no/end_line_pos are optional. Example SQL:
`SELECT NULL FROM {{ a_jinja_templated_table }};`

`sqlfluff lint --dialect ansi --format json` gives the following error
among others:
```
{"start_line_no": 1, "start_line_pos": 21, "code": "TMP", "description":
"Undefined jinja template variable: 'a_jinja_templated_table'", "name":
"", "warning": false}
```

As one can see there is no end_line_no/end_line_pos.

* Add golangci-lint fixer (dense-analysis#4853)

Closes dense-analysis#4616

* Fixed copy-paste misstakes and added filter to docs

* Added test vader file for yq

* Fixed and updated the test case

---------

Co-authored-by: Walter Kaunda <[email protected]>
Co-authored-by: rudolf ordoyne <[email protected]>
Co-authored-by: Bea Hughes <[email protected]>
Co-authored-by: benjos1234 <[email protected]>
Co-authored-by: Coacher <[email protected]>
Co-authored-by: Ian Stapleton Cordasco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants