Stop the completion tests from failing randomly

dense-analysis · Nov 21, 2017 · 5556fcb · 5556fcb
1 parent cf599f4
commit 5556fcb
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/autoload/ale/completion.vim b/autoload/ale/completion.vim
@@ -282,6 +282,15 @@ function! s:TimerHandler(...) abort
     endif
 endfunction
 
+" Stop any completion timer that is queued. This is useful for tests.
+function! ale#completion#StopTimer() abort
+    if s:timer_id != -1
+        call timer_stop(s:timer_id)
+    endif
+
+    let s:timer_id = -1
+endfunction
+
 function! ale#completion#Queue() abort
     let l:time = get(b:, 'ale_complete_done_time', 0)
 
@@ -298,9 +307,7 @@ function! ale#completion#Queue() abort
         let b:ale_completion_info.request_id = 0
     endif
 
-    if s:timer_id != -1
-        call timer_stop(s:timer_id)
-    endif
+    call ale#completion#StopTimer()
 
     let s:timer_id = timer_start(g:ale_completion_delay, function('s:TimerHandler'))
 endfunction

diff --git a/test/test_completion.vader b/test/test_completion.vader
@@ -41,6 +41,10 @@ After:
 
   delfunction CheckCompletionCalled
 
+  " Stop any timers we left behind.
+  " This stops the tests from failing randomly.
+  call ale#completion#StopTimer()
+
   runtime autoload/ale/completion.vim
   runtime autoload/ale/lsp.vim