Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(async): improve docs for stabilization #4803

Merged
merged 5 commits into from
May 22, 2024

Conversation

crowlKats
Copy link
Member

No description provided.

@crowlKats crowlKats requested a review from kt3k as a code owner May 21, 2024 14:30
@crowlKats crowlKats requested a review from dsherret May 21, 2024 14:30
@github-actions github-actions bot added the async label May 21, 2024
Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (0ef767f) to head (d9bfb72).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4803      +/-   ##
==========================================
- Coverage   91.94%   91.50%   -0.44%     
==========================================
  Files         486      486              
  Lines       41327    41329       +2     
  Branches     5321     5284      -37     
==========================================
- Hits        37998    37820     -178     
- Misses       3272     3450     +178     
- Partials       57       59       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

async/abortable.ts Outdated Show resolved Hide resolved
@crowlKats crowlKats merged commit e3f63dc into denoland:main May 22, 2024
12 checks passed
@crowlKats crowlKats deleted the doc-async branch May 22, 2024 00:40
* @typeParam T The type of the provided and returned promise.
* @param p The promise to make abortable.
* @param signal The signal to abort the promise with.
* @returns A promise that can be aborted.
*
* @example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would've been nice to have a snippet title to avoid having it as "Example 1" in JSR. Ditto for other @example code snippets.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel like if its a single example, it being Example 1 is fine. most scenarios have only really one example that makes sense to have, and describing it will seem a bit too much. though definitively should be enforced for multiple examples

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've now added example titles to the list of checks for the doc checker. Please feel free to review #4841.

async/debounce.ts Show resolved Hide resolved
webgpu/create_capture.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants