fix(testing/assert): inequality of -0 and 0 (#1783)

denoland · Jan 4, 2022 · 43c5946 · 43c5946
1 parent a2a2cb5
commit 43c5946
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/testing/asserts.ts b/testing/asserts.ts
@@ -137,6 +137,9 @@ export function equal(c: unknown, d: unknown): boolean {
       }
       return a.getTime() === b.getTime();
     }
+    if (typeof a === "number" && typeof b === "number") {
+      return Number.isNaN(a) && Number.isNaN(b) || a === b;
+    }
     if (Object.is(a, b)) {
       return true;
     }

diff --git a/testing/asserts_test.ts b/testing/asserts_test.ts
@@ -23,6 +23,18 @@ import {
 } from "./asserts.ts";
 import { bold, gray, green, red, stripColor, yellow } from "../fmt/colors.ts";
 
+Deno.test("testingEqualDifferentZero", () => {
+  assert(equal(0, -0));
+  assert(equal(0, +0));
+  assert(equal(+0, -0));
+  assert(equal([0], [-0]));
+  assert(equal(["hello", 12.21, 0], ["hello", 12.21, -0]));
+  assert(equal(["hello", 12.21, 0], ["hello", 12.21, +0]));
+  assert(equal(["hello", 12.21, -0], ["hello", 12.21, +0]));
+  assert(equal({ msg: "hello", case: 0 }, { msg: "hello", case: -0 }));
+  assert(equal({ msg: "hello", array: [0] }, { msg: "hello", array: [-0] }));
+});
+
 Deno.test("testingEqual", function (): void {
   assert(equal("world", "world"));
   assert(!equal("hello", "world"));