fix(encoding): base58 decoding (#2982)

denoland · Dec 13, 2022 · 01696ce · 01696ce
1 parent 01ec142
commit 01696ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/encoding/base58.ts b/encoding/base58.ts
@@ -129,7 +129,7 @@ export function decode(b58: string): Uint8Array {
     length = i;
   });
 
-  const validOutput = output.filter((item) => item ?? false);
+  const validOutput = output.filter((item) => item !== undefined);
 
   if (ones > 0) {
     const onesResult = Array.from({ length: ones }).fill(0, 0, ones);

diff --git a/encoding/base58_test.ts b/encoding/base58_test.ts
@@ -14,6 +14,7 @@ const testSetString = [
   ["foobar", "t1Zv2yaZ"],
   ["Hello World!", "2NEpo7TZRRrLZSi2U"],
   [new Uint8Array([0, 0, 0, 40, 127, 180, 205]), "111233QC4"],
+  [new Uint8Array([10, 0, 10]), "4MpV"],
 ];
 
 const testSetBinary = testSetString.map(([data, b58]) => {