Fix race condition between handshake and waker registration #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that wakers are registered in a thread-safe manner.
This is a latent multi-threaded bug that could happen, though it's a very, very tight race to win.
In a multi-threaded runtime, there was a very small window for a race:
send_handshake
part of the handshake task completes, and the handshake then tries to wake any deferred wakers (which do not exist). The task is about to complete but then the thread gets parked by the CPU.This wasn't easy to repro on my Mac -- I had to explicitly add a thread sleep after the poll_read check for
handle.is_finished()
, but before we set the waker. This would trigger the race pretty much every time.