Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening lib.deno.url.d.ts causes frequent LSP errors #25999

Closed
jespertheend opened this issue Oct 2, 2024 · 6 comments · Fixed by #26699
Closed

opening lib.deno.url.d.ts causes frequent LSP errors #25999

jespertheend opened this issue Oct 2, 2024 · 6 comments · Fixed by #26699
Assignees
Labels
bug Something isn't working correctly lsp related to the language server

Comments

@jespertheend
Copy link
Contributor

Version: Deno 1.46.3

Create a .ts file with the following contents:

type Foo = URLPatternInit;

then ctrl/cmd click URLPatternInit

image

But please prioritize #16439 over this one because error messages like these are probably the main reason why I leave the Deno extension disabled most of the time. Either a setting or just not showing notifications for errors like these in the first place would solve this issue and many future issues alike.

@bartlomieju bartlomieju added bug Something isn't working correctly lsp related to the language server labels Oct 2, 2024
@nayeemrmn nayeemrmn self-assigned this Oct 3, 2024
@lucacasonato lucacasonato removed the bug Something isn't working correctly label Oct 3, 2024
@nayeemrmn
Copy link
Collaborator

I'm struggling to reproduce. Is there a particular the way the workspace is setup or lack thereof?

@jespertheend
Copy link
Contributor Author

Seems like I have to toggle the typescript.tsserver.experimental.enableProjectDiagnostics setting on and off to be able to reproduce this. I have no idea why 😅

@yazan-abdalrahman
Copy link
Contributor

Can I work on it?
nayeemrmn

@yazan-abdalrahman
Copy link
Contributor

@nayeemrmn @jespertheend
To reproduce it, toggle "typescript":false and if you make any updates in deno.json, the issue disappears.

@nayeemrmn
Copy link
Collaborator

We don't support typescript.tsserver.experimental.enableProjectDiagnostics, there isn't any way we can plug the built-in TS server to disable those.

Let's continue in denoland/vscode_deno#437.

@nayeemrmn nayeemrmn closed this as not planned Won't fix, can't repro, duplicate, stale Oct 8, 2024
@jespertheend
Copy link
Contributor Author

I'm also seeing this when toggling typescript.enablePromptUseWorkspaceTsdk, typescript.format.enable and many other settings on and off again, so I don't think this is caused by denoland/vscode_deno#437 specifically.

@nayeemrmn nayeemrmn reopened this Oct 8, 2024
@lucacasonato lucacasonato added the bug Something isn't working correctly label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly lsp related to the language server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants