lsp: better handling of non-actionable error messages

[jespertheend]

Is your feature request related to a problem? Please describe.

The Deno extension shows a lot of error notifications, more than any of the extensions I'm currently using. Some examples include:

• When a test fails. This is fine if an error occurs that causes the tests to not run properly, but a notification is also shown when the testing ui already shows the failing tests.
• Error when selecting linter message in jsdoc comment. vscode_deno#591 (though now fixed)
• lsp: Request completionItem/resolve failed. #15400
• EOF while parsing a value at line 1 column 0 vscode_deno#609
• opening lib.deno.url.d.ts causes frequent LSP errors #25999

This leads to frustration because these notifications don't work like toasts, so you have to manually dismiss them.
This also takes attention away from notifications that actually do matter.

Describe the solution you'd like

The solution here is probably less trivial than I expect it to be. Ideally there would be different settings for different kind of notifications. So the user can choose which notifications to subscribe to.
But if this is not feasible, a single option to suppress all errors would be helpful as well I think.

[kitsonk]

In many cases, when we get an error back from the integrated TypeScript language server, we send it to the client as an error, which creates a pop, but ultimately the error is unactionable, and often transitory, where typing a little bit more resolves the internal TypeScript language server debug issue. We should in a lot of cases, just continue to log these out to the extension log, but just return an empty return value instead of erroring.

[lemmon-714]

Please, as VSCode has no means to enable extension error popups (yes I'm aware of "silence notifications", does not affect extension-error-popups) I have to constantly yet unpredictably close those unactionable irritations.

[bartlomieju]

@crowlKats please take a look

[lemmon-714]

Any progress on this? It's extremely irritating. Thank you

[bartlomieju]

Any progress on this? It's extremely irritating. Thank you

Which messages are you getting most often?

[lemmon-714]

It's calm right now; this one just appeared:

It looks quite familiar though. Might be it. The one I'm talking about happens when editing files, so they of course don't make much sense while I'm in the process of typing.

thank you!

[bartlomieju]

That message should be now fixed in V1.29.2. let me know if this happens after upgrade

[lemmon-714]

Might be that I'm in the wrong repo, this is my version:

[bartlomieju]

Might be that I'm in the wrong repo, this is my version:

This is the version of the vscode_deno plugin, what is the Deno version if you evaluate deno --version in the terminal?

[lemmon-714]

Ah, makes sense, I assumed it's an issue with the plugin. Was on an older version of Deno indeed, updating now. Thank you!

[nayeemrmn]

Error notifications are usually bugs. Let's continue in individual issues if they come up.

[jespertheend]

I'm sorry but I really don't think notifications are intended for that use case. All extensions I know like eslint, prettier and even TypeScript itself use the output panel for errors.
Errors often occur when hovering over symbols or when modifying files, which makes the notifications frequent and annoying.
On top of that, vscode has no built-in way to suppress error notifications so the only thing you can do to get rid of them is to disable the extension. 😕

[nayeemrmn]

@jespertheend The notifications are the default behaviour when an LSP response returns an error, we don't do anything in particular to cause that. I see them for rust-analyzer sometimes as well. When I say bugs I mean bugs with the LSP to be clear. If you know of any triggers currently, please report them.